This comment is being posted, but the submission does not add a net new owners file, and therefore should not need to run. Only a modification is taking place. The verbiage also says that an OWNERS file is being created which is not true.
If they create a net-new organization/chart etc., we'll know because we'll see a net-new OWNERS file (which causes chart lock checks to trigger and update).
This problem doesn't cause any issues with certification, but rather just makes our CI noisier than it needs to be.
Example: https://github.com/openshift-helm-charts/charts/pull/1313#issuecomment-2022936529
This comment is being posted, but the submission does not add a net new owners file, and therefore should not need to run. Only a modification is taking place. The verbiage also says that an OWNERS file is being created which is not true.
The verbiage problem appears to be this line. https://github.com/openshift-helm-charts/development/blob/main/.github/workflows/check-locks-on-owners-submission.yml#L171
We check
net-new-owners-fileas a boolean, but we need to check it as a string 'true' instead as is done here: https://github.com/openshift-helm-charts/development/blob/main/.github/workflows/mercury_bot.yml#L161That's because the value of that variable has a string of non-zero length, which makes it truthy.
Further, if we don't want to post the comment at all, we need to repeat that evaluation in the
ifstatement for the update task here: https://github.com/openshift-helm-charts/development/blob/main/.github/workflows/check-locks-on-owners-submission.yml#L157C18-L157C19I don't think we need to update the issue if the OWNERS file is just being modified. If the user modifies the chart name, category, or organization, we'll know because the directory structure won't match the content of the OWNERS file here: https://github.com/openshift-helm-charts/development/blob/main/.github/workflows/check-locks-on-owners-submission.yml#L121-L131
If they create a net-new organization/chart etc., we'll know because we'll see a net-new OWNERS file (which causes chart lock checks to trigger and update).