Problem is that this issue was never communicated to the user nor to us maintainers. While the pipeline do fails, the PR is already merged at this stage (merge occurs at the end of the "chart-verifier" job, run previously), and no error appears. We should at least be informed.
I believe the correct solution is to add a comment on the PR that pings maintainers in case of a failure in the "Release Chart" job.
See: https://github.com/openshift-helm-charts/charts/actions/runs/8518766581/job/23331558923?pr=1359
Reason for the fail is tracked in another issue.
In this pipeline, the "Release Chart" job failed. As a result, the index was never updated and the chart never actually released. Also, this allowed the partner to update the chart in a new PR, although that shouldn't be allowed (see the index check: https://github.com/openshift-helm-charts/charts/blob/main/scripts/src/checkprcontent/checkpr.py#L224)
Problem is that this issue was never communicated to the user nor to us maintainers. While the pipeline do fails, the PR is already merged at this stage (merge occurs at the end of the "chart-verifier" job, run previously), and no error appears. We should at least be informed.
I believe the correct solution is to add a comment on the PR that pings maintainers in case of a failure in the "Release Chart" job.