Closed mgoerens closed 4 months ago
FYI failure in CI were caused by either:
In both cases, I tend to think those issues are caused by GitHub slowness, and not by the changes in this PR. Will retry in a second when I push an updated commit.
@mgoerens LGTM. Good catch.
Two non-blocking comments:
The only thing I'd mention here is that this approach, which I've found only recently, feels a bit simpler to comment on a PR. I like github-script, but in some cases it requires more error handling than I really care to deal with. Here, it looks fine to me.
Secondly, a failure to index a merged chart might warrant a more direct ping than a GH comment. We may consider Slack comms in the future.
Non-blocking, so nothing to change here.
Thanks!
Add a GitHub comment if an error occurs during the update of the helm index that pings the maintainers.
fix #341