Closed mgoerens closed 1 month ago
@komish Reg. logging, yes I have a plan. I want to have a main()
function in the precheck
package, that instantiates the Submission and run the required checks. Exceptions should be caught and logged there.
I will also take some time to compare what is being logged in the legacy code vs what is being raised in the new code. Should be relatively close, but I'll double check if I missed anything important before the switch.
This is a port of the two following checks, performed at the end of the checkpr script, to the Chart data structure:
Reviewers, please see https://github.com/openshift-helm-charts/development/blob/main/scripts/src/checkprcontent/checkpr.py#L224-L276 for the original code (still in use at the moment).