openshift-helm-charts / development

0 stars 17 forks source link

Update script dependencies and update fn calls to match #359

Closed komish closed 1 month ago

komish commented 2 months ago

Context:

I'm looking to enable dependabot for this repository soon. Before that happens, I ran dependabot in a fork and ran the E2E testing to see how it behaved. It's look all green after a couple of signature changes (captured here), so I think this should be in good shape.

Please keep an eye out for anything strange that we think may be a result of these dependency changes. Several packages iterated major versions.

Dependabot enablement will happen later, along with syft/grype.

Summary:

komish commented 2 months ago

@komish LGTM...but as a side question, I suppose only semver.isvalid needed changing in our code?

Correct. Did I change it somewhere unexpected or miss a spot?