search

openshift-homeroom / workshop-dashboard

Adds content hosting to workshop terminals.
Apache License 2.0
47 stars 37 forks source link

"Useless" scrollbar #30

Closed kaovilai closed 5 years ago

kaovilai commented 5 years ago

Workshop div can show useless scrollbar on systems with always visible scrollbar taking up valuable content space.

It can result in single useless scrollbar. If content inside is longer, there will be another scrollbar that comes up. That is intended.

This issue is regarding the static scrollbar that stays there visible on system configured with always visible scrollbars such as by default Windows systems. macOS may also inherit this issue if user have set their setting to show scrollbar. image

For testing on macOS Set the following image

Preliminary testing inside Chrome's DevTools shows that css that targets iframe-div class were not inherited properly.

Applying overflow: hidden to the div directly solves this issue.

Possible fix include adding the following to CSS

div#workshop-div {
    overflow: hidden;
}

image

cc: @thoraxe

GrahamDumpleton commented 5 years ago

The issue relates to the overflow-y: scroll that is defined in CSS for .iframe-div. If that is removed, works okay then on desktop. Need to check whether removing that will cause an issue on a tablet with iOS though. It may have in part been added because of that.

GrahamDumpleton commented 5 years ago

Fix in 3.4.1.