openshift-instruqt / instruqt

Repository for the Red Hat and OpenShift Developers Learning Portal, powered by Instruqt.
https://developers.redhat.com/learn/openshift
32 stars 36 forks source link

cicd-with-ansible-automation-platform-and-jenkins-on-openshift_lab_add #226

Closed nageshredhat closed 1 year ago

nageshredhat commented 1 year ago

Hi there, I'm done with CI/CD lab. sending you PR. Please accept it. If you found any issues please let me know.

ryanj commented 1 year ago

Hello @nageshredhat! I'm having trouble following the instructions in challenge 2. I couldn't find where to add credentials for the step that says For credentials select credentials type “OpenShift or Kubernetes API Bearer Token” We need 3 component to require to fill in the credentials..

Is the next step under "Resources" -> "Credentials" -> "Add"? I tried that page but I wasn't sure what info to use for the credential name, or the CA data. I also wasn't sure if I should paste the API bearer token from the token page, or from the output of oc get secret cicd -o json | jq '.data.token' | xargs | base64 --decode > containergroup-sa.token

ryanj commented 1 year ago

Thanks for the updates. Section 2 is still a little difficult for me to follow, but I managed to progress further down the page: https://play.instruqt.com/openshift/tracks/cicd-with-ansible-automation-platform-and-jenkins-on-openshift

Although, I'm currently stuck on the Ping step, which makes me think I messed up something earlier in the process.

I'll give it another try tomorrow

nageshredhat commented 1 year ago

Thanks @Ryan Jarvinen @.***> , I know this lab is a bit difficult to understand. can we have a short call together & i will explain the end to end process. In a single call we can wrap up multiple doubts & accordingly I can fix those issues much quickly rather than one by one. Also we can publish this lab early. Or do you have any better suggestions? Let me know.

Thanks & Regards

On Tue, Mar 7, 2023 at 5:34 AM ryan jarvinen @.***> wrote:

Thanks for the updates. Section 2 is still a little difficult for me to follow, but I managed to progress further down the page:

https://play.instruqt.com/openshift/tracks/cicd-with-ansible-automation-platform-and-jenkins-on-openshift

Although, I'm currently stuck on the Ping step, which makes me think I messed up something earlier in the process.

I'll give it another try tomorrow

— Reply to this email directly, view it on GitHub https://github.com/openshift-instruqt/instruqt/pull/226#issuecomment-1457242895, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2RQBCTY6BQDC53CAVAUMHDW2Z3R7ANCNFSM6AAAAAAVJSN5Y4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Nagesh Rathod Sr. Software Engineer @RedHat Developers BU Team

ryanj commented 1 year ago

@nageshredhat Sorry to spread the review over multiple days. I don't have a ton of time to work on this, and each test run has been taking an hour or more.

This content is MUCH longer than most of our other tracks and requires a bit more time to review. We have been trying to limit the length of our tracks as much as possible in order to increase the completion rate for each. I can merge this as-is, but I would definitely recommend attempting a shorter rewrite if possible. We are shooting for 20 mins or less per track, as user engagement stats often drop off when presented with longer content like this.

I had some challenges navigating the content in sections 2 and 3. I have not yet completed the third challenge successfully. The step that involves copying and editing before pasting is difficult to follow. Usually, we would export some variables to enable users to avoid the yaml editing step.

The last thing that we need before merging this PR, is to add a "Call to Action" at the end of the content. Would you mind adding the following to the end of the course?:

# What's Next?

Congratulations on completing this lab. Ready to continue learning?

* Visit the [Red Hat Developer learning page](https://developers.redhat.com/learn) for more labs and resources
* [Want to try a free, instant 30-day OpenShift cluster? Get started with the Developer Sandbox for Red Hat OpenShift](https://developers.redhat.com/developer-sandbox)

Don't forget to finish the lab and rate your experience on the next page. Thanks for playing!

After the PR is merged, we can follow up with the Drupal team to make it available on developers.redhat.com

ryanj commented 1 year ago

Also, happy to discuss any of this over a video chat if it would help... I'm available in US/Pacific hours

nageshredhat commented 1 year ago

Hello @ryanj thanks for having call with me. Added the context of what's next.

ryanj commented 1 year ago

Thanks @nageshredhat