search

openshift-knative / eventing-hyperfoil-benchmark

Apache License 2.0
2 stars 8 forks source link

Add Receiver fixes #21

Closed pierDipi closed 2 years ago

pierDipi commented 3 years ago

Bring receiver fixes from https://github.com/rvansa/eventing-hyperfoil-benchmark to this repo.

pierDipi commented 3 years ago

/cc @rvansa

openshift-ci[bot] commented 3 years ago

@pierDipi: GitHub didn't allow me to request PR reviews from the following users: rvansa.

Note that only openshift-knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-knative/eventing-hyperfoil-benchmark/pull/21#issuecomment-967330157): >/cc @rvansa Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rvansa commented 3 years ago

@pierDipi Great, thanks!

Btw. did you have any issues with the header ce-runId vs. ce-runid? Request.getHeader(...) should not be case-sensitive (and proxies are free to rewrite case in headers).

pierDipi commented 3 years ago

Btw. did you have any issues with the header ce-runId vs. ce-runid? Request.getHeader(...) should not be case-sensitive (and proxies are free to rewrite case in headers).

I didn't check if that could cause issues (likely it doesn't) but I'd leave it as in your repository since it's what we're currently using.

pierDipi commented 3 years ago

/cc @matzew

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/eventing-hyperfoil-benchmark/blob/main/OWNERS)~~ [matzew,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment