search

openshift-knative / hack

CI tooling to improve and automate CI and release management
Apache License 2.0
4 stars 16 forks source link

Preserve newer Tekton task images in Konflux pipelines #206

Closed pierDipi closed 3 months ago

pierDipi commented 3 months ago

This handles the case task images are updated with renovate, like in https://github.com/openshift-knative/eventing-istio/pull/273

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/hack/blob/main/OWNERS)~~ [creydr,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
creydr commented 3 months ago

This is great. Thanks a lot!

pierDipi commented 3 months ago

One further issue is that https://github.com/openshift-knative/eventing-istio/pull/273 updates on release-next will not be preserved but that's a bit the nature of release next :(

creydr commented 3 months ago

I though about excluding the main branch from this logic, and running the updating the pipeline definition file (https://github.com/openshift-knative/hack/blob/main/pkg/konfluxgen/docker-build.yaml) each time. So we have the latest tags on main / release-next, but ignore them on the release branches (as we have there this logic from this PR). To not run the renovate jobs on release-next (like https://github.com/openshift-knative/eventing-istio/pull/273), we could check to configure a renovate.json and disable it for this branch (https://docs.renovatebot.com/configuration-options/)