openshift-knative / hack

CI tooling to improve and automate CI and release management
Apache License 2.0
4 stars 16 forks source link

Generate Konflux components for serverless operator #213

Closed pierDipi closed 2 months ago

pierDipi commented 2 months ago

Push the SO components to the hack repository since when we cut a new branch we could potentially have 2 components with the same "release version" on 2 different branches and coordinating the merge of 2 pull requests on 2 different branches is challenging and difficult.


Tested with:

FIRST_KONFLUX_BRANCH=release-1.32 CONTAINER_ENGINE=docker make generate-ci-no-clean

while also enabling Konflux on Eventing 1.12-1.14 branches.

This produces:

For example:

apiVersion: appstudio.redhat.com/v1alpha1
kind: Component
metadata:
  annotations:
    build.appstudio.openshift.io/pipeline: '{"name":"docker-build","bundle":"latest"}'
  name: knative-eventing-apiserver-receive-adapter-release-v112
spec:
  componentName: knative-eventing-apiserver-receive-adapter
  application: serverless-operator-release-133

  build-nudges-ref:

    - "serverless-bundle-release-133"

  source:
    git:
      url: https://github.com/openshift-knative/eventing.git
      context: 
      dockerfileUrl: openshift/ci-operator/knative-images/apiserver_receive_adapter/Dockerfile
      revision: release-v1.12
apiVersion: appstudio.redhat.com/v1alpha1
kind: Component
metadata:
  annotations:
    build.appstudio.openshift.io/pipeline: '{"name":"docker-build","bundle":"latest"}'
  name: serverless-bundle-release-133
spec:
  componentName: serverless-bundle
  application: serverless-operator-release-133

  source:
    git:
      url: https://github.com/openshift-knative/serverless-operator.git
      context: 
      dockerfileUrl: olm-catalog/serverless-operator/Dockerfile
      revision: release-1.33
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/hack/blob/main/OWNERS)~~ [creydr,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mgencur commented 2 months ago

Looks good to me. Feel free to unhold.

pierDipi commented 2 months ago

/unhold