search

openshift-knative / hack

CI tooling to improve and automate CI and release management
Apache License 2.0
4 stars 14 forks source link

Fix: Move setting the user after post-build-instructions #247

Closed creydr closed 1 week ago

creydr commented 1 week ago

When we set the user too early, some post-build-instructions wont work correctly (for example symlinks - see https://redhat-internal.slack.com/archives/CKR568L8G/p1725551082332669?thread_ts=1725374750.726439&cid=CKR568L8G)

mgencur commented 1 week ago

/lgtm

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/hack/blob/main/OWNERS)~~ [creydr,mgencur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment