openshift-knative / hack

CI tooling to improve and automate CI and release management
Apache License 2.0
4 stars 14 forks source link

tzdata is part of ubi8-minimal #250

Closed pierDipi closed 1 week ago

pierDipi commented 1 week ago

We don't need to install it:

pierdipi@pierdipi openshift-knative-hack (main) $ docker run -ti --rm registry.access.redhat.com/ubi8/ubi-minimal /bin/bash
Unable to find image 'registry.access.redhat.com/ubi8/ubi-minimal:latest' locally
latest: Pulling from ubi8/ubi-minimal
Digest: sha256:a47c89f02b39a98290f88204ed3d162845db0a0c464b319c2596cfd1e94b444e
Status: Downloaded newer image for registry.access.redhat.com/ubi8/ubi-minimal:latest
[root@552ae7b1786c /]# rpm -qa tzdata
tzdata-2024a-1.el8.noarch

Also noticed the current command is no-op:

[2/2] STEP 2/7: RUN microdnf install tzdata

(microdnf:5003): librhsm-WARNING **: 06:22:34.990: Found 0 entitlement certificates

(microdnf:5003): librhsm-WARNING **: 06:22:34.994: Found 0 entitlement certificates
Downloading metadata...
Downloading metadata...
Downloading metadata...
Nothing to do.

This helps with Hermetic builds https://github.com/openshift-knative/eventing/pull/793/checks?check_run_id=29859057727

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/hack/blob/main/OWNERS)~~ [creydr,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment