search

openshift-knative / hack

CI tooling to improve and automate CI and release management
Apache License 2.0
4 stars 14 forks source link

Update core libraries to ditch replace directive #265

Closed dsimansk closed 1 week ago

dsimansk commented 1 week ago

OPEN FILE VIEW AT YOUR OWN RISK! (a lot changes related to vendoring)

Only relevant changes are here: 7ce6fa2a96dc348d1e1fa46c11c7dd1afdbcac08

A lot of vendoring in other commit.

/cc @pierDipi @mgencur @creydr

dsimansk commented 1 week ago

Ditching replace should enable straight-forward install, e.g. go install github.com/openshift-knative/cmd/generate.

pierDipi commented 1 week ago

Thanks, I like this one and tests are green too!

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/hack/blob/main/OWNERS)~~ [pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment