openshift-knative / hack

CI tooling to improve and automate CI and release management
Apache License 2.0
4 stars 16 forks source link

Enterprise Contract integration test #270

Closed rudyredhat1 closed 1 month ago

rudyredhat1 commented 1 month ago

Hi all, As per the discussion in konflux slack channel, we need to add EC test manually. JIRA ticket = https://issues.redhat.com/browse/SRVCOM-3253 Slack thread link = https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1724829902061669)

I am trying to add integration-test-scenario-template.yaml which can be used for the EC tests. Can anyone please have a look?

Thanks /cc @pierDipi @creydr @mgencur

pierDipi commented 1 month ago

I think we want to also add the new resource integrationtestscenarios here https://github.com/openshift-knative/hack/blob/7587057e3c32be19f860767c26b3cbf20b2aea25/cmd/konflux-apply/manifests/gh-action-role.yaml#L9-L12 (and also re-create the token before merging https://github.com/openshift-knative/hack/blob/main/cmd/konflux-apply/README.md#revoke-and-recreate-token)

creydr commented 1 month ago

I think we want to also add the new resource integrationtestscenarios here

https://github.com/openshift-knative/hack/blob/7587057e3c32be19f860767c26b3cbf20b2aea25/cmd/konflux-apply/manifests/gh-action-role.yaml#L9-L12

(and also re-create the token before merging https://github.com/openshift-knative/hack/blob/main/cmd/konflux-apply/README.md#revoke-and-recreate-token)

Good point. Updating the gh-action-runner role should be enough I guess.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, rudyredhat1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/hack/blob/main/OWNERS)~~ [pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment