openshift-knative / hack

CI tooling to improve and automate CI and release management
Apache License 2.0
4 stars 16 forks source link

Fix pipelinetemplate with correct repo name to align with imagerepository #271

Closed creydr closed 2 months ago

creydr commented 2 months ago

After #268 we're still getting quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-eventing-istio-controller: authentication required build failures. This is because I missed to update the pipeline template with the correct output-image. This PR addresses it.

So https://github.com/openshift-knative/hack/blob/f774ac2c3557ddf3cc5ae970f7cd915330bd25fa/pkg/konfluxgen/pipeline-run.template.yaml#L33

and https://github.com/openshift-knative/hack/blob/f774ac2c3557ddf3cc5ae970f7cd915330bd25fa/pkg/konfluxgen/pipeline-run.template.yaml#L36

need to match

https://github.com/openshift-knative/hack/blob/f774ac2c3557ddf3cc5ae970f7cd915330bd25fa/pkg/konfluxgen/imagerepository.template.yaml#L12

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/hack/blob/main/OWNERS)~~ [creydr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment