Add workflow in each repo to apply Konflux manifests on changes

openshift-knative / hack

CI tooling to improve and automate CI and release management

Apache License 2.0

4 stars 16 forks source link

Add workflow in each repo to apply Konflux manifests on changes #305

Open creydr opened 1 month ago

creydr commented 1 month ago

add a reusable action to apply the Konflux manifests
Adds a workflow to each repo & branch which have Konflux enabled calling the above reusable action. This allows to apply the manifests directly after changes in the .konflux/ directory in the repositories and does not need the periodic runs from hack repo anymore

/hold as we need to move the KONFLUX_SA_TOKEN secret from the hack repo to the org (when we agreed on this PR)

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/hack/blob/main/OWNERS)~~ [creydr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pierDipi commented 1 month ago

why not calling the existing workflow in this repo instead of duplicating it everywhere? That would solve also the possibility for CI config to be different when merging PRs so from each repo we would call the generate CI and Konflux apply

pierDipi commented 1 month ago

Similar to what we already do for SO, I think we discussed that as the approach we would have taken https://github.com/openshift-knative/serverless-operator/commit/45eccfe5e170b06adb4b85c40d303752d44aba55

creydr commented 1 month ago

why not calling the existing workflow in this repo instead of duplicating it everywhere? That would solve also the possibility for CI config to be different when merging PRs so from each repo we would call the generate CI and Konflux apply

Not sure if I understand you correctly, but isn't this what I am proposing in my PR? I made the existing workflow to apply the konflux manifests "reusable" and only add a new workflow to the other repos, which calls this workflow:

https://github.com/openshift-knative/hack/blob/6cc93a788c9809ba150449eb496a7aeab5d2bb88/pkg/konfluxgen/apply-konflux-manifests-workflow.yaml#L12

This allows us to still manage the core workflow in this repo and run the workflow only when it's needed (on pushes to the downstream repos)

openshift-merge-robot commented 4 days ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.