openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 66 forks source link

Restart OLM pods to prevent OCPBUGS-3139 #2594

Closed ReToCode closed 5 months ago

ReToCode commented 5 months ago

Changes

ReToCode commented 5 months ago

/override "Lint"

openshift-ci[bot] commented 5 months ago

@ReToCode: Overrode contexts on behalf of ReToCode: Lint

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2594#issuecomment-2034535353): >/override "Lint" > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ReToCode commented 5 months ago

Seems to look good. @pierDipi @mgencur a bit hacky, but I think this should help for now. PTAL.

ReToCode commented 5 months ago

/unhold

mgencur commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [ReToCode,mgencur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mgencur commented 5 months ago

@ReToCode Hmm. I think the workaround is applied too late. We might hit it earlier when installing Cert Manager:

 08:55:08.218 DEBUG:   [[ $(oc get deploy -n cert-manager cert-manager --no-headers | wc -l) != 1 ]] : Waiting until non-zero (max 600 sec.)
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
09:06:12.613 ERROR:   Time out of 600 exceeded 

Hitting this in https://github.com/openshift-knative/eventing-kafka-broker/pull/1047