openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 66 forks source link

[SRVKS-1120] Use webhook context for secret data keys #2596

Closed skonto closed 5 months ago

skonto commented 5 months ago

Fixes JIRA #SRVKS-1120

Proposed Changes

ReToCode commented 5 months ago

/override "Lint"

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [ReToCode,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@ReToCode: Overrode contexts on behalf of ReToCode: Lint

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2596#issuecomment-2036222410): >/override "Lint" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
skonto commented 5 months ago

@ReToCode in order to remove that env var I have opened an upstream PR here: https://github.com/knative/pkg/pull/3006.

ReToCode commented 5 months ago

/unhold