openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

Introduce install-for-mesh-e2e make target #2629

Closed mgencur closed 2 months ago

mgencur commented 2 months ago

The make target installs products/dependencies that are required for running E2E tests with mesh. This is to enable running "installation" and "tests" in separate CI containers and report failures specifically for each phase. Running install and test separately would require these:

SKIP_MESH_AUTH_POLICY_GENERATION=true make install-for-mesh-e2e
make test-upstream-e2e-mesh-testonly

Related slack discussion with product-to-product QE.

Proposed Changes

-

-

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [ReToCode,mgencur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD b50fa6b4d617be499cfe3cb6852bb2268962e505 and 2 for PR HEAD 6fbc88eaebc8c9da173296583b7d755cd428bb31 in total

creydr commented 2 months ago

@mgencur can you check on the failures? (Just to get it in before the 1.33 cut)

mgencur commented 2 months ago

@creydr I have re-run the "Generated files are committed" and it passes now. This PR is ready for a merge.