search

openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

Add links for arm64 artifacts to consoleclidownload.go #2642

Closed mvinkler closed 2 months ago

mvinkler commented 2 months ago

Fixes JIRA SRVCOM-3099

Proposed Changes

:bug: fix - add missing links for arm64 kn to OCP Command Line Tools page

Kaustubh-pande commented 2 months ago

@mvinkler we need to update the expected number- https://github.com/openshift-knative/serverless-operator/blob/7d60f8643fcaf72e79e8301eef52694e8e06478a/test/servinge2e/verify_deploy_resources_test.go#L26

pierDipi commented 2 months ago 
    0s
{Failed  === RUN   TestKnConsoleCLIDownload
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-linux-arm64.tar.gz" size 19 less than 10MB
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-darwin-arm64.tar.gz" size 19 less than 10MB
--- FAIL: TestKnConsoleCLIDownload (0.12s)
}
pierDipi commented 2 months ago

/cherry-pick release-1.33

openshift-cherrypick-robot commented 2 months ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2642#issuecomment-2104177091): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mvinkler commented 2 months ago

@dsimansk any idea why the Content-Length header returns 19 bytes for both arm downloads?

 === RUN   TestKnConsoleCLIDownload
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-linux-arm64.tar.gz" size 19 less than 10MB
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-darwin-arm64.tar.gz" size 19 less than 10MB
dsimansk commented 2 months ago

@dsimansk any idea why the Content-Length header returns 19 bytes for both arm downloads?

 === RUN   TestKnConsoleCLIDownload
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-linux-arm64.tar.gz" size 19 less than 10MB
    verify_deploy_resources_test.go:46: Failed to verify kn CCD, kn artifact "https://kn-openshift-serverless.apps.serverless-ocp-4-15-amd64-aws-us-east-1-mms7d.serverless.devcluster.openshift.com/kn-darwin-arm64.tar.gz" size 19 less than 10MB

Well, midstream image doesn't have those archives enabled, or they are named differently.

We only have the following archives at the moment: https://github.com/openshift-knative/client/blob/main/openshift/ci-operator/knative-images/client/Dockerfile.cliartifacts

dsimansk commented 2 months ago

@mvinkler it should pass even the download test with changes made in midstream kn-cli-artifacts.

https://github.com/openshift-knative/client/pull/378

dsimansk commented 2 months ago

In addition we synced with @Kaustubh-pande on the naming scheme. In the cli image we will keep archive names with kn-macos-* to keep it consistent.

dsimansk commented 2 months ago

Current structure in midstream image:

[root@c30a67b9bb13 kn]# ls -lR
.:
total 12
-rw-rw-r--. 1 root root 11357 May 13 19:22 LICENSE
drwxr-xr-x. 2 root root    35 May 13 19:39 linux_amd64
drwxr-xr-x. 2 root root    35 May 13 19:39 linux_arm64
drwxr-xr-x. 2 root root    37 May 13 19:39 linux_ppc64le
drwxr-xr-x. 2 root root    35 May 13 19:39 linux_s390x
drwxr-xr-x. 2 root root    35 May 13 19:39 macos_amd64
drwxr-xr-x. 2 root root    35 May 13 19:39 macos_arm64
drwxr-xr-x. 2 root root    34 May 13 19:39 windows

./linux_amd64:
total 47696
-rw-r--r--. 1 root root 48837246 May 13 19:38 kn-linux-amd64.tar.gz

./linux_arm64:
total 44480
-rw-r--r--. 1 root root 45546738 May 13 19:38 kn-linux-arm64.tar.gz

./linux_ppc64le:
total 44412
-rw-r--r--. 1 root root 45475797 May 13 19:38 kn-linux-ppc64le.tar.gz

./linux_s390x:
total 47040
-rw-r--r--. 1 root root 48165706 May 13 19:38 kn-linux-s390x.tar.gz

./macos_amd64:
total 47408
-rw-r--r--. 1 root root 48542499 May 13 19:38 kn-macos-amd64.tar.gz

./macos_arm64:
total 8
-rw-r--r--. 1 root root 4134 May 13 19:38 kn-macos-arm64.tar.gz

./windows:
total 48084
-rw-r--r--. 1 root root 49236005 May 13 19:39 kn-windows-amd64.zip
dsimansk commented 2 months ago

/approve /lgtm

For tests /hold /cherry-pick release-1.33

openshift-cherrypick-robot commented 2 months ago

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2642#issuecomment-2108676168): >/approve >/lgtm > >For tests >/hold >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dsimansk commented 2 months ago

/retest

dsimansk commented 2 months ago

/lgtm /unhold

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, mvinkler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dsimansk commented 2 months ago

/retest-required

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 9bbfebbce86aaef8404f437e51057fa6305f85a8 and 2 for PR HEAD 2c80806342b0142d06df4214dda41b97c21138d0 in total

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 30d73a424586cf628ea287456f3709c65510017c and 1 for PR HEAD 2c80806342b0142d06df4214dda41b97c21138d0 in total

dsimansk commented 2 months ago

Pendig update on CI config side first: https://github.com/openshift/release/pull/51996

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 2781e569c75b9080b005830c31841290d1337a38 and 0 for PR HEAD 2c80806342b0142d06df4214dda41b97c21138d0 in total

dsimansk commented 2 months ago

/hold

openshift-ci[bot] commented 2 months ago

@mvinkler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/415-upstream-e2e-kafka-aws-415 2c80806342b0142d06df4214dda41b97c21138d0 link false /test 415-upstream-e2e-kafka-aws-415

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dsimansk commented 2 months ago

/test 415-operator-e2e-aws-415

dsimansk commented 2 months ago

/unhold

mvinkler commented 2 months ago

/retest-required

openshift-cherrypick-robot commented 2 months ago

@pierDipi: new pull request created: #2662

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2642#issuecomment-2104177091): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.