Incorporate new upstream Serving encryption

openshift-knative / serverless-operator

Main source repository for Openshift Serverless

Apache License 2.0

43 stars 65 forks source link

Incorporate new upstream Serving encryption #2663

Closed ReToCode closed 1 month ago

ReToCode commented 1 month ago

Fixes JIRA https://issues.redhat.com/browse/SRVKS-1198

Proposed Changes

Install cert-manager always (as Downstream Serving tests now need it as well)
Deploy Serving cert-manager issuers & certificates (aligned with upstream, we can't use the Eventing ones)
Remove internal-encryption in favour of system-internal-tls and cluster-local-domain-tls
Add a new test to make sure Serving encryption works
Refactor test helpers to be shared

Please consider my comments for simpler review.

ReToCode commented 1 month ago

/test 415-upstream-e2e-aws-415

ReToCode commented 1 month ago

/test 415-upstream-e2e-aws-415

ReToCode commented 1 month ago

/unhold /assign @skonto /assign @mgencur

mgencur commented 1 month ago

LGTM

skonto commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [ReToCode,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment