search

openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

Create prometheus token instead of expecting it to exist #2673

Closed mgencur closed 1 month ago

mgencur commented 1 month ago

The behaviour changed across OCP versions. With 4.10 and older it was recommended to get the existing token. For later versions it's recommended to create a new token every time. And on 4.16 the older aproach doesn't work anymore.

Fixes https://issues.redhat.com/browse/SRVCOM-3132

Proposed Changes

mgencur commented 1 month ago

/test ?

openshift-ci[bot] commented 1 month ago

@mgencur: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2673#issuecomment-2126403172): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mgencur commented 1 month ago

/test 416-operator-e2e-aws-416 /test 412-operator-e2e-aws-412

mgencur commented 1 month ago

/cherry-pick release-1.33

openshift-cherrypick-robot commented 1 month ago

@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2673#issuecomment-2126406887): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mgencur commented 1 month ago

/test 416-operator-e2e-aws-416

openshift-ci[bot] commented 1 month ago

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-operator-e2e-aws-416 6cb5371e2735738690fde1ac90424bb0f29a270d link true /test 416-operator-e2e-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mgencur commented 1 month ago

The failures on OCP 4.16 are unrelated to my changes. Failed while waiting for a ServiceAccount to be deleted in these:

test/extensione2erekt: TestKafkaSourceBinaryEvent
test/extensione2erekt: TestSourceChannelBasedKafkaBrokerKsvc
maschmid commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [mgencur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 month ago

@mgencur: new pull request created: #2675

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2673#issuecomment-2126406887): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.