openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

Initial Konflux setup #2674

Closed creydr closed 1 month ago

creydr commented 1 month ago

https://github.com/openshift-knative/eventing/pull/616 for adding custom build pipelines for eventing-controller

creydr commented 1 month ago

/hold will do some tests to get around the infinite renovate PRs

creydr commented 1 month ago

/unhold as we have 09a1470710faf19d126a41abefe71bfd1e6cef36 to prevent infinite renovate PRs

pierDipi commented 1 month ago

Feel free to merge manually

/cc @ReToCode @mgencur

pierDipi commented 1 month ago

/cc @Kaustubh-pande @rudyredhat1

openshift-ci[bot] commented 1 month ago

@pierDipi: GitHub didn't allow me to request PR reviews from the following users: rudyredhat1.

Note that only openshift-knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2674#issuecomment-2137097847): >/cc @Kaustubh-pande @rudyredhat1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Kaustubh-pande commented 1 month ago

Hi, @creydr, this seems to me like everything is push to quay.io, for downstream/product-build if we want to use it, the builds are available at registry.redhat.io ? for this we need to do more configuration at konflux ? do you have any doc link for downstream/product-build of konflux ?

creydr commented 1 month ago

Hi, @creydr, this seems to me like everything is push to quay.io, for downstream/product-build if we want to use it, the builds are available at registry.redhat.io ? for this we need to do more configuration at konflux ? do you have any doc link for downstream/product-build of konflux ?

Hey @Kaustubh-pande, as clarified via Slack, for now the images are pushed to quay.io and at some point we aim to merge the downstream&midstream build pipelines into one Konflux build pipeline.

pierDipi commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/konflux/OWNERS)~~ [pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment