openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

Only run Serving encryption tests for kourier #2680

Closed ReToCode closed 1 month ago

ReToCode commented 1 month ago

Proposed Changes

ReToCode commented 1 month ago

/assign @skonto /assign @mgencur

ReToCode commented 1 month ago

system-internal-tls definitely makes no sense with istio. I'm currently testing if cluster-local-domain-tls would work (just to know), even though we do not plan on supporting that with istio either.

ReToCode commented 1 month ago

Lint is unrelated, separate PR so

/override "validate/lint"

ReToCode commented 1 month ago

/override "Lint"

openshift-ci[bot] commented 1 month ago

@ReToCode: Overrode contexts on behalf of ReToCode: Lint

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2680#issuecomment-2141359394): >/override "Lint" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
skonto commented 1 month ago

@ReToCode

I'm currently testing if cluster-local-domain-tls would work (just to know), even though we do not plan on supporting that with istio either.

Is this tested by creating a separate gateway and a workload accessing with https the ingress gaetway, with Istio in mesh mode? Is not this a feature RHOAI wanted to solve the tls issue (option 1)?

ReToCode commented 1 month ago

/test 415-test-upgrade-aws-415

ReToCode commented 1 month ago

@skonto @mgencur PTAL

mgencur commented 1 month ago

LGTM

skonto commented 1 month ago

Maybe get the lint one in first? Then stamp this one?

ReToCode commented 1 month ago

Should not matter, but we can 👍

skonto commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [ReToCode,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD cf1d68977c39ad3aa98cb58f48031f540e9f3538 and 2 for PR HEAD 342a41c98d05900d0adee57d86f4d1857602f262 in total