Closed ReToCode closed 1 month ago
/assign @skonto /assign @mgencur
system-internal-tls
definitely makes no sense with istio. I'm currently testing if cluster-local-domain-tls
would work (just to know), even though we do not plan on supporting that with istio either.
Lint is unrelated, separate PR so
/override "validate/lint"
/override "Lint"
@ReToCode: Overrode contexts on behalf of ReToCode: Lint
@ReToCode
I'm currently testing if cluster-local-domain-tls would work (just to know), even though we do not plan on supporting that with istio either.
Is this tested by creating a separate gateway and a workload accessing with https the ingress gaetway, with Istio in mesh mode? Is not this a feature RHOAI wanted to solve the tls issue (option 1)?
/test 415-test-upgrade-aws-415
@skonto @mgencur PTAL
LGTM
Maybe get the lint one in first? Then stamp this one?
Should not matter, but we can 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ReToCode, skonto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD cf1d68977c39ad3aa98cb58f48031f540e9f3538 and 2 for PR HEAD 342a41c98d05900d0adee57d86f4d1857602f262 in total
Proposed Changes