Add https port on knative-local-gateway (sync with upstream)

openshift-knative / serverless-operator

Main source repository for Openshift Serverless

Apache License 2.0

43 stars 65 forks source link

Add https port on knative-local-gateway (sync with upstream) #2681

Closed ReToCode closed 1 month ago

ReToCode commented 1 month ago

Proposed Changes

Add https port on knative-local-gateway (sync with upstream https://github.com/knative-extensions/net-istio/blob/main/config/203-local-gateway.yaml#L58)
Needed if we want to enable cluster-local-domain-tls for istio at some point

/assign @skonto

ReToCode commented 1 month ago

/override "Lint"

openshift-ci[bot] commented 1 month ago

@ReToCode: Overrode contexts on behalf of ReToCode: Lint

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2681#issuecomment-2141365126): >/override "Lint" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

skonto commented 1 month ago

/lgtm

skonto commented 1 month ago

/hold for tests

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [ReToCode,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ReToCode commented 1 month ago

/test 415-test-upgrade-aws-415

ReToCode commented 1 month ago

/unhold