search

openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

Remove hardcoded kafka-config-logging XML #2688

Closed pierDipi closed 1 month ago

pierDipi commented 1 month ago

Use the default logging configuration as specified in the manifests

pierDipi commented 1 month ago

/cherry-pick release-1.33

openshift-cherrypick-robot commented 1 month ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2688#issuecomment-2149243359): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
pierDipi commented 1 month ago

/retest

pierDipi commented 1 month ago

/cc @maschmid @mgencur

pierDipi commented 1 month ago

/cherry-pick release-1.32

openshift-cherrypick-robot commented 1 month ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.32 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2688#issuecomment-2149698561): >/cherry-pick release-1.32 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
maschmid commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD dac8160808ec89c79b20dba5930bf8e2553299ce and 2 for PR HEAD 36da2a0ad310992856162349bea3e647d0f8ed2a in total

openshift-cherrypick-robot commented 1 month ago

@pierDipi: new pull request created: #2689

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2688#issuecomment-2149243359): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 month ago

@pierDipi: new pull request created: #2690

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2688#issuecomment-2149698561): >/cherry-pick release-1.32 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.