search

openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 66 forks source link

Support patch release validation #2691

Closed pierDipi closed 4 months ago

pierDipi commented 4 months ago

It will fix the issue of wrong image references on 1.33 (and when we will create 1.34 branch)

Tested in https://github.com/openshift-knative/serverless-operator/pull/2692

pierDipi commented 4 months ago

/cherry-pick release-1.33

openshift-cherrypick-robot commented 4 months ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2691#issuecomment-2151775532): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [ReToCode,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 4 months ago

@pierDipi: new pull request could not be created: failed to create pull request against openshift-knative/serverless-operator#release-1.33 from head openshift-cherrypick-robot:cherry-pick-2691-to-release-1.33: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift-knative:release-1.33 and openshift-cherrypick-robot:cherry-pick-2691-to-release-1.33"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2691#issuecomment-2151775532): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
pierDipi commented 4 months ago

@pierDipi: new pull request could not be created: failed to create pull request against openshift-knative/serverless-operator#release-1.33 from head openshift-cherrypick-robot:cherry-pick-2691-to-release-1.33: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift-knative:release-1.33 and openshift-cherrypick-robot:cherry-pick-2691-to-release-1.33"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

I did the backport manually