openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

fix KnativeKafka controller-autoscaler-keda enablement #2716

Closed maschmid closed 1 week ago

maschmid commented 1 week ago

The documented way of activatinr keda autoscaling in KnativeKafka is .spec.config.kafka-features.controller-autoscaler-keda

Proposed Changes

https://docs.openshift.com/serverless/1.33/eventing/event-sources/serverless-kafka-developer-source.html#serverless-kafka-source-autoscale-keda_serverless-kafka-developer-source

mgencur commented 1 week ago

/lgtm

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, maschmid, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [mgencur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment