search

openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

[SRVKS-1249] Add DomainMapping cleanup for obsolete resources #2743

Closed dsimansk closed 19 hours ago

dsimansk commented 4 days ago

Fixes SRVKS-1249

Proposed Changes

Backport upstream's cleanup job into S-O operator.

/wip /cc @skonto @ReToCode

dsimansk commented 4 days ago

/hold

skonto commented 3 days ago

We need to backport it to 1.33.0 right?

dsimansk commented 1 day ago

/cherry-pick release-1.33

openshift-cherrypick-robot commented 1 day ago

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2743#issuecomment-2208957207): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
skonto commented 1 day ago

Thanks for your patience @dsimansk! good stuff! /lgtm

/hold for @ReToCode for a last check

openshift-ci[bot] commented 23 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [ReToCode,dsimansk,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ReToCode commented 23 hours ago

@dsimansk cherry pick or do you want to manually backport?

skonto commented 20 hours ago

/unhold

skonto commented 20 hours ago

/cherry-pick release-1.33

openshift-cherrypick-robot commented 20 hours ago

@skonto: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2743#issuecomment-2210377208): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
skonto commented 20 hours ago

/cherry-pick release-1.32

openshift-cherrypick-robot commented 20 hours ago

@skonto: once the present PR merges, I will cherry-pick it on top of release-1.32 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2743#issuecomment-2210377600): >/cherry-pick release-1.32 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 19 hours ago

@dsimansk: new pull request created: #2759

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2743#issuecomment-2208957207): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 19 hours ago

@skonto: new pull request created: #2760

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2743#issuecomment-2210377600): >/cherry-pick release-1.32 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.