openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

Change kube rbac proxy's default log level to zero and make it configurable #2749

Closed skonto closed 1 day ago

skonto commented 2 days ago

Fixes JIRA #

Proposed Changes

matzew commented 1 day ago

@skonto this is for all three CRs? KnativeServing, KnativeEventing and our custom KnativeKafka ?

matzew commented 1 day ago

/retest

skonto commented 1 day ago

this is for all three CRs?

It should be as InjectRbacProxyContainer is called from these components.

pierDipi commented 1 day ago

/lgtm /approve

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [pierDipi,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pierDipi commented 1 day ago

/cherry-pick release-1.33

pierDipi commented 1 day ago

/cherry-pick release-1.32

openshift-cherrypick-robot commented 1 day ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2749#issuecomment-2209264954): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 day ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.32 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2749#issuecomment-2209264997): >/cherry-pick release-1.32 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 day ago

@pierDipi: new pull request created: #2756

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2749#issuecomment-2209264954): >/cherry-pick release-1.33 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 day ago

@pierDipi: new pull request created: #2757

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2749#issuecomment-2209264997): >/cherry-pick release-1.32 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.