search

openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
43 stars 65 forks source link

MSINTEROP-1166: :bug: Change the mappingMethod to add for IdP #2761

Closed cardil closed 3 weeks ago

cardil commented 3 weeks ago

Fixes JIRA https://issues.redhat.com/browse/MSINTEROP-1166

Proposed Changes

/kind bug

Refs:

openshift-ci-robot commented 3 weeks ago

@cardil: This pull request references MSINTEROP-1166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2761): >Fixes JIRA https://issues.redhat.com/browse/MSINTEROP-1166 > >## Proposed Changes > >- :bug: Change the mappingMethod to add for IdP > >/kind bug > >## Refs: > >- https://access.redhat.com/solutions/4824871 >- https://issues.redhat.com/browse/MSINTEROP-1166 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-knative%2Fserverless-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cardil commented 3 weeks ago

/test 415-ui-tests-aws-415

openshift-ci[bot] commented 3 weeks ago

@cardil: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/2761#issuecomment-2210563630): >/test 415-ui-tests-aws-415 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cardil commented 3 weeks ago

/test 415-ui-e2e-aws-415

cardil commented 3 weeks ago

The UI tests passed on ROSA as well. See: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/54060/rehearse-54060-periodic-ci-cardil-serverless-operator-msinterop-1166-p2p-serverless-p2p-rosa/1809203159520776192/artifacts/serverless-p2p-rosa/ui-e2e-tests/

Let's merge

jrangelramos commented 3 weeks ago

/lgtm

cardil commented 3 weeks ago

/approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: cardil, jrangelramos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment