search

openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
59 stars 69 forks source link

Use knative-main as tag for webhook #3042

Closed ReToCode closed 1 week ago

ReToCode commented 1 week ago

Proposed Changes

/assign @skonto

ReToCode commented 1 week ago

/override "Generated files are committed"

openshift-ci[bot] commented 1 week ago

@ReToCode: Overrode contexts on behalf of ReToCode: Generated files are committed

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3042#issuecomment-2490299385): >/override "Generated files are committed" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ReToCode commented 1 week ago

/override ?

openshift-ci[bot] commented 1 week ago

@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3042#issuecomment-2490302222): >/override ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ReToCode commented 1 week ago

/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix-metadata-webhook" /override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-must-gather-135"

openshift-ci[bot] commented 1 week ago

@ReToCode: Overrode contexts on behalf of ReToCode: Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix-metadata-webhook, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-must-gather-135

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3042#issuecomment-2490302759): >/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix-metadata-webhook" >/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-must-gather-135" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
skonto commented 1 week ago

/lgtm /approve

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [ReToCode,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
skonto commented 1 week ago

Eventing tests failed. @ReToCode should we re-run or just override?

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 1886150224fcc28cce72dd450908e45c65e74d97 and 2 for PR HEAD ee7401027a976245fa73f90abbc3d026d9665ff1 in total

skonto commented 1 week ago

/test 417-test-upgrade-aws-417

ReToCode commented 1 week ago

Eventing tests failed. @ReToCode should we re-run or just override?

I'm fine with both

skonto commented 1 week ago

/override ci/prow/417-test-upgrade-aws-417

openshift-ci[bot] commented 1 week ago

@skonto: Overrode contexts on behalf of skonto: ci/prow/417-test-upgrade-aws-417

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3042#issuecomment-2491425096): >/override ci/prow/417-test-upgrade-aws-417 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
skonto commented 1 week ago

/override "ci/prow/417-images"

openshift-ci[bot] commented 1 week ago

@skonto: Overrode contexts on behalf of skonto: ci/prow/417-images

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3042#issuecomment-2491440313): >/override "ci/prow/417-images" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
skonto commented 1 week ago

/override "ci/prow/417-operator-e2e-aws-417" /override "ci/prow/417-test-upgrade-aws-417" /override "ci/prow/417-upstream-e2e-aws-417"

openshift-ci[bot] commented 1 week ago

@skonto: Overrode contexts on behalf of skonto: ci/prow/417-operator-e2e-aws-417, ci/prow/417-test-upgrade-aws-417, ci/prow/417-upstream-e2e-aws-417

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3042#issuecomment-2491442042): >/override "ci/prow/417-operator-e2e-aws-417" >/override "ci/prow/417-test-upgrade-aws-417" >/override "ci/prow/417-upstream-e2e-aws-417" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.