search

openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
59 stars 69 forks source link

Add script to generate override snapshot #3045

Closed creydr closed 2 days ago

creydr commented 1 week ago

Script to generate the override snapshot based on the CSV file

openshift-ci[bot] commented 1 week ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

creydr commented 3 days ago 
Error: no attestations associated with quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-client-kn@sha256:96b9b74ef35c0f8fb32ec3b743e585fb7402fa3da35608ae870f9119ba8a0cef
main.go:62: error during command execution: no attestations associated with quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-client-kn@sha256:96b9b74ef35c0f8fb32ec3b743e585fb7402fa3da35608ae870f9119ba8a0cef

Seems attestation images are not pushed, when something in the pipeline fails.

/hold

creydr commented 3 days ago

Also sometimes the repourl contains the .git suffix and sometimes not. e.g.

https://github.com/openshift-knative/client

vs

https://github.com/openshift-knative/client.git
mgencur commented 3 days ago

/lgtm

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/release-1.35/OWNERS)~~ [creydr,mgencur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
creydr commented 2 days ago 
Error: no attestations associated with quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-client-kn@sha256:96b9b74ef35c0f8fb32ec3b743e585fb7402fa3da35608ae870f9119ba8a0cef
main.go:62: error during command execution: no attestations associated with quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-client-kn@sha256:96b9b74ef35c0f8fb32ec3b743e585fb7402fa3da35608ae870f9119ba8a0cef

Seems attestation images are not pushed, when something in the pipeline fails.

/hold

As discussed, this is also an indicator, that something is wrong. So failing early here is OK

/unhold

openshift-ci[bot] commented 2 days ago

@creydr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/417-test-upgrade-aws-417 3d970b0c60cdb6310c9032851a492faa9f22beb6 link unknown /test 417-test-upgrade-aws-417

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
creydr commented 2 days ago

/test 417-test-upgrade-aws-417

openshift-ci[bot] commented 2 days ago

New changes are detected. LGTM label has been removed.