Separate installing cert manager operator and certificates

mgencur commented 5 days ago

Allows for testing proper CA setup downstream instead of self-signed certificates and still re-using the installation function for certmanager operator.

Fixes JIRA #

Proposed Changes

-

maschmid commented 5 days ago

/lgtm

openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [mgencur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mgencur commented 5 days ago

/cherry-pick release-1.34

openshift-cherrypick-robot commented 5 days ago

@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.34 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3054#issuecomment-2500724237): >/cherry-pick release-1.34 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

pierDipi commented 5 days ago

/cherry-pick release-1.35

openshift-cherrypick-robot commented 5 days ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.35 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3054#issuecomment-2501193045): >/cherry-pick release-1.35 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci-robot commented 5 days ago

/retest-required

Remaining retests: 0 against base HEAD c9eb519cfff2016485e157a8f1f761c9559eda22 and 2 for PR HEAD 5dc986481fe462eee25063c68e31a5e435168231 in total

openshift-ci-robot commented 5 days ago

/retest-required

Remaining retests: 0 against base HEAD c9eb519cfff2016485e157a8f1f761c9559eda22 and 2 for PR HEAD 5dc986481fe462eee25063c68e31a5e435168231 in total

openshift-ci-robot commented 5 days ago

/retest-required

Remaining retests: 0 against base HEAD c9eb519cfff2016485e157a8f1f761c9559eda22 and 2 for PR HEAD 5dc986481fe462eee25063c68e31a5e435168231 in total

openshift-ci-robot commented 5 days ago

/retest-required

Remaining retests: 0 against base HEAD c9eb519cfff2016485e157a8f1f761c9559eda22 and 2 for PR HEAD 5dc986481fe462eee25063c68e31a5e435168231 in total

openshift-ci-robot commented 5 days ago

/retest-required

Remaining retests: 0 against base HEAD c9eb519cfff2016485e157a8f1f761c9559eda22 and 2 for PR HEAD 5dc986481fe462eee25063c68e31a5e435168231 in total

openshift-ci-robot commented 5 days ago

/retest-required

Remaining retests: 0 against base HEAD c9eb519cfff2016485e157a8f1f761c9559eda22 and 2 for PR HEAD 5dc986481fe462eee25063c68e31a5e435168231 in total

mgencur commented 4 days ago

Our Dockerfile for Index image is now pulling registry.ci.openshift.org/knative/release-1.35.0:serverless-bundle on line 14 as the bundle now exists. It doesn't pull the the previously built "image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-bundle:latest" and the release-1.35.0 bundle references images at registry.redhat.io which are not pullable yet. We'll need to fix this.