search

openshift-knative / serverless-operator

Main source repository for Openshift Serverless
Apache License 2.0
59 stars 69 forks source link

Fix SO index #3056

Closed pierDipi closed 4 days ago

pierDipi commented 4 days ago

Our Dockerfile for Index image is now pulling registry.ci.openshift.org/knative/release-1.35.0:serverless-bundle on line 14 as the bundle now exists.

It doesn't pull the the previously built image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-bundle:latest and the release-1.35.0 bundle references images at registry.redhat.io which are not pullable yet.

Originally reported here: https://github.com/openshift-knative/serverless-operator/pull/3054#issuecomment-2503220449

pierDipi commented 4 days ago

/cherry-pick release-1.35

openshift-cherrypick-robot commented 4 days ago

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.35 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3056#issuecomment-2503285477): >/cherry-pick release-1.35 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mgencur commented 4 days ago

/lgtm

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-knative/serverless-operator/blob/main/OWNERS)~~ [creydr,mgencur,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
skonto commented 4 days ago

We need this after each cut? Do we need to document it in the template as in here: https://github.com/openshift-knative/serverless-operator/issues/2989?

mgencur commented 4 days ago

We need this after each cut? Do we need to document it in the template as in here

No. That's a one-time change. We had that before because we wanted to be able to install Serverless operator from "main" and from release branch without rebuilding the Bundle (i.e. faster setup - for periodic jobs or local runs). But now we need to rebuild the Bundle every time because we replace registry.redhat.io references with quay.io. So, the bundle will be rebuilt correctly for each branch.

skonto commented 4 days ago

No. That's a one-time change.

Is there going to be a 1.36 entry (registry.ci.openshift.org/knative/release-1.36.0:serverless-bundle) in there with registry.redhat.io references?

mgencur commented 4 days ago

Is there going to be a 1.36 entry in there with registry.redhat.io references?

No.

pierDipi commented 4 days ago

We need this after each cut? Do we need to document it in the template as in here: #2989?

no, I don't think so

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD c9eb519cfff2016485e157a8f1f761c9559eda22 and 2 for PR HEAD cd12d326871a53ba14cf7c00d41f83d1a143a6ac in total

pierDipi commented 4 days ago 
error getting cluster operators: Get "https://api.serverless-ocp-4-17-amd64-aws-us-east-1-6544x.serverless.devcluster.openshift.com:6443/apis/config.openshift.io/v1/clusteroperators": dial tcp 3.227.130.244:6443: connect: connection refused
ClusterOperators:
    clusteroperators are missing

Can we merge anyway?

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD 511168ab8c84d76504417e6a8ecdb77dafc4c0e0 and 1 for PR HEAD cd12d326871a53ba14cf7c00d41f83d1a143a6ac in total

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD 511168ab8c84d76504417e6a8ecdb77dafc4c0e0 and 2 for PR HEAD cd12d326871a53ba14cf7c00d41f83d1a143a6ac in total

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD 511168ab8c84d76504417e6a8ecdb77dafc4c0e0 and 2 for PR HEAD cd12d326871a53ba14cf7c00d41f83d1a143a6ac in total

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD 511168ab8c84d76504417e6a8ecdb77dafc4c0e0 and 2 for PR HEAD cd12d326871a53ba14cf7c00d41f83d1a143a6ac in total

openshift-cherrypick-robot commented 4 days ago

@pierDipi: new pull request created: #3061

In response to [this](https://github.com/openshift-knative/serverless-operator/pull/3056#issuecomment-2503285477): >/cherry-pick release-1.35 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.