search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
56 stars 131 forks source link

use imagestream instead of image #101

Open AsherShoshan opened 4 years ago

AsherShoshan commented 4 years ago

in DeploymentConfig, the imagestream should be used instead ogf the 'normal' image https://github.com/openshift-kni/cnf-features-deploy/blob/master/feature-configs/demo/dpdk/deployment-config.yaml#L34-L36

slintes commented 4 years ago

@SchSeba is that something you can handle?

SchSeba commented 4 years ago

Hi @AsherShoshan the part is a PodSpec resource there is no imagestream there.

You can validate that by change it and try to run oc apply -f <yaml> it should fail.

The imagestream is in the trigger part that will update the deployment every time a new image was pushed to the registry.