search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

OCPBUGS-32756: Add documentation to explain how to select the multicluster-operators-subscription image #1890

Closed edcdavid closed 6 months ago

edcdavid commented 6 months ago

This is to add a note about using the reference argocd-openshift-gitops-patch.json ( link) in disconnected environments where the image urls contained in the file may need to be adpated.

edcdavid commented 6 months ago

/cc @imiller0

openshift-ci-robot commented 6 months ago

@edcdavid: This pull request references Jira Issue OCPBUGS-32756, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1890): >This is to add a note about using the reference argocd-openshift-gitops-patch.json ( [link](ztp/gitops-subscriptions/argocd/deployment/argocd-openshift-gitops-patch.json)) in disconnected environments where the image urls contained in the file may need to be adpated. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
edcdavid commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@edcdavid: This pull request references Jira Issue OCPBUGS-32756, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mpmaruthu

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1890#issuecomment-2086046044): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1890#issuecomment-2086046678): >@edcdavid: This pull request references [Jira Issue OCPBUGS-32756](https://issues.redhat.com//browse/OCPBUGS-32756), which is valid. The bug has been moved to the POST state. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.16.0) matches configured target version for branch (4.16.0) >* bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mpmaruthu

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1890#issuecomment-2086046044): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

edcdavid commented 6 months ago

//cc @irinamihai @sabbir-47

edcdavid commented 6 months ago

/cc @irinamihai @sabbir-47

openshift-ci[bot] commented 6 months ago

@edcdavid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ran-profile bdd9ebb09f76a1cfc7a19c2118407adde810b72a link false /test e2e-aws-ran-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
irinamihai commented 6 months ago

/lgtm

irinamihai commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edcdavid, irinamihai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [irinamihai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

@edcdavid: Jira Issue OCPBUGS-32756: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32756 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1890): >This is to add a note about using the reference argocd-openshift-gitops-patch.json ( [link](ztp/gitops-subscriptions/argocd/deployment/argocd-openshift-gitops-patch.json)) in disconnected environments where the image urls contained in the file may need to be adpated. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
edcdavid commented 4 months ago

/cherrypick release-4.15

openshift-cherrypick-robot commented 4 months ago

@edcdavid: #1890 failed to apply on top of branch "release-4.15":

Applying: ztp: Add documentation to explain how to select the multicluster-operators-subscription image
.git/rebase-apply/patch:18: trailing whitespace.
   1. Select the multicluster-operators-subscription image to work with your ACM version. 
.git/rebase-apply/patch:19: trailing whitespace.

.git/rebase-apply/patch:24: trailing whitespace.

.git/rebase-apply/patch:25: trailing whitespace.
   The version of the multicluster-operators-subscription image should match the ACM version. For instance, for ACM 2.10, use the `multicluster-operators-subscription-rhel9:v2.10` image.  
.git/rebase-apply/patch:26: trailing whitespace.
   For ACM 2.9, use the `multicluster-operators-subscription-rhel8:v2.9` image.  
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   ztp/gitops-subscriptions/argocd/README.md
Falling back to patching base and 3-way merge...
Auto-merging ztp/gitops-subscriptions/argocd/README.md
CONFLICT (content): Merge conflict in ztp/gitops-subscriptions/argocd/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ztp: Add documentation to explain how to select the multicluster-operators-subscription image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1890#issuecomment-2206069114): >/cherrypick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
edcdavid commented 4 months ago

/cherrypick release-4.14

openshift-cherrypick-robot commented 4 months ago

@edcdavid: #1890 failed to apply on top of branch "release-4.14":

Applying: ztp: Add documentation to explain how to select the multicluster-operators-subscription image
.git/rebase-apply/patch:18: trailing whitespace.
   1. Select the multicluster-operators-subscription image to work with your ACM version. 
.git/rebase-apply/patch:19: trailing whitespace.

.git/rebase-apply/patch:24: trailing whitespace.

.git/rebase-apply/patch:25: trailing whitespace.
   The version of the multicluster-operators-subscription image should match the ACM version. For instance, for ACM 2.10, use the `multicluster-operators-subscription-rhel9:v2.10` image.  
.git/rebase-apply/patch:26: trailing whitespace.
   For ACM 2.9, use the `multicluster-operators-subscription-rhel8:v2.9` image.  
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   ztp/gitops-subscriptions/argocd/README.md
Falling back to patching base and 3-way merge...
Auto-merging ztp/gitops-subscriptions/argocd/README.md
CONFLICT (content): Merge conflict in ztp/gitops-subscriptions/argocd/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ztp: Add documentation to explain how to select the multicluster-operators-subscription image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1890#issuecomment-2206126605): >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.