openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

CNF-12277: chore: move LVMS to mgmt cores #1891

Closed jakobmoellerdev closed 5 months ago

jakobmoellerdev commented 6 months ago

This adds a namespace annotation so that the LVMS workloads will be scheduled into the management core set instead of the isolated cores.

openshift-ci-robot commented 6 months ago

@jakobmoellerdev: This pull request references CNF-12277 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1891): >This adds a namespace annotation so that the LVMS workloads will be scheduled into the management core set instead of the isolated cores. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

Hi @jakobmoellerdev. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jakobmoellerdev commented 6 months ago

@imiller0 do you mind checking this for correctness and adding ok-to-test?

imiller0 commented 5 months ago

/ok-to-test

jakobmoellerdev commented 5 months ago

/test e2e-aws-ran-profile

jakobmoellerdev commented 5 months ago

/test e2e-aws-ran-profile

lack commented 5 months ago

/override ci/prow/e2e-aws-ran-profile

We really need to fix this job :(

openshift-ci[bot] commented 5 months ago

@lack: Overrode contexts on behalf of lack: ci/prow/e2e-aws-ran-profile

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1891#issuecomment-2124570372): >/override ci/prow/e2e-aws-ran-profile > >We really need to fix this job :( Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lack commented 5 months ago

/lgtm

jakobmoellerdev commented 5 months ago

@imiller0 @lack would need an approved here, could one of you PTAL?

lack commented 5 months ago

/approve (Though I don't know if it'll let me because I also LGTM'd)

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, lack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [lack] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sabbir-47 commented 3 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 months ago

@sabbir-47: new pull request created: #1970

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1891#issuecomment-2230588584): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.