search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

OCPBUGS-33004: ztp: move IPsec directory to argocd/example #1892

Closed sabinaaledort closed 5 months ago

sabinaaledort commented 6 months ago

Move IPsec directory to argocd/example where such examples lives and configure IPsec on day-1 at install-time.

openshift-ci-robot commented 6 months ago

@sabinaaledort: This pull request references Jira Issue OCPBUGS-33004, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1892): >Move IPsec directory to argocd/example where such examples lives and configure IPsec on day-1 at install-time. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sabinaaledort commented 6 months ago

/hold

openshift-ci-robot commented 6 months ago

@sabinaaledort: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1892): >Move IPsec directory to argocd/example where such examples lives and configure IPsec on day-1 at install-time. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sabinaaledort commented 6 months ago

/retest

sabinaaledort commented 6 months ago

/hold cancel

sabinaaledort commented 6 months ago

/cc @yuvalk @lack

yuvalk commented 6 months ago

/retitle OCPBUGS-333004: ztp: move IPsec directory to argocd/example

openshift-ci-robot commented 6 months ago

@sabinaaledort: No Jira issue with key OCPBUGS-333004 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1892): >Move IPsec directory to argocd/example where such examples lives and configure IPsec on day-1 at install-time. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yuvalk commented 6 months ago

/retitle OCPBUGS-33004: ztp: move IPsec directory to argocd/example

openshift-ci-robot commented 6 months ago

@sabinaaledort: This pull request references Jira Issue OCPBUGS-33004, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1892): >Move IPsec directory to argocd/example where such examples lives and configure IPsec on day-1 at install-time. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yuvalk commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@yuvalk: This pull request references Jira Issue OCPBUGS-33004, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (obochan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1892#issuecomment-2096195686): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sabinaaledort commented 6 months ago

/cc @sabbir-47 @yliu127

lack commented 6 months ago

/override ci/prow/e2e-aws-ran-profile

openshift-ci[bot] commented 6 months ago

@lack: Overrode contexts on behalf of lack: ci/prow/e2e-aws-ran-profile

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1892#issuecomment-2102587201): >/override ci/prow/e2e-aws-ran-profile Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lack commented 6 months ago

/lgtm

yuvalk commented 5 months ago

/lgtm /approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sabinaaledort, yuvalk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [yuvalk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

@sabinaaledort: Jira Issue OCPBUGS-33004: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33004 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1892): >Move IPsec directory to argocd/example where such examples lives and configure IPsec on day-1 at install-time. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sabbir-47 commented 5 months ago

/cherrypick release-4.16

openshift-cherrypick-robot commented 5 months ago

@sabbir-47: #1892 failed to apply on top of branch "release-4.16":

Applying: ztp: move IPsec directory to argocd/example
error: mode change for ztp/source-crs/optional-extra-manifest/ipsec/build.sh, which is not in current HEAD
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ztp: move IPsec directory to argocd/example
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1892#issuecomment-2137260963): >/cherrypick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.