search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

OCPBUGS-33364: ztp: Add IBU examples #1896

Closed Missxiaoguo closed 6 months ago

Missxiaoguo commented 6 months ago
openshift-ci-robot commented 6 months ago

@Missxiaoguo: This pull request references Jira Issue OCPBUGS-33364, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1896): >- Add both PGT and ACM policygenerator examples to create IBU policies. >- Change oadp cm policy generation through PGT instead of a given policy file. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Missxiaoguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [Missxiaoguo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Missxiaoguo commented 6 months ago

/uncc @lack @simon3z

Missxiaoguo commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@Missxiaoguo: This pull request references Jira Issue OCPBUGS-33364, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mpmaruthu

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1896#issuecomment-2098786538): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1896#issuecomment-2098786800): >@Missxiaoguo: This pull request references [Jira Issue OCPBUGS-33364](https://issues.redhat.com//browse/OCPBUGS-33364), which is valid. The bug has been moved to the POST state. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.16.0) matches configured target version for branch (4.16.0) >* bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mpmaruthu

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1896#issuecomment-2098786538): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Missxiaoguo commented 6 months ago

/cc @imiller0 @sabbir-47 @jc-rh

leo8a commented 6 months ago

/lgtm

Missxiaoguo commented 6 months ago

/retest-required

openshift-ci[bot] commented 6 months ago

@Missxiaoguo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ran-profile 544c8b2b7aea148e089f9b2d91d6a10d503bd3f7 link false /test e2e-aws-ran-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Missxiaoguo commented 6 months ago

/retest-required

openshift-ci-robot commented 6 months ago

@Missxiaoguo: Jira Issue OCPBUGS-33364: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33364 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1896): >- Add both PGT and ACM policygenerator examples to create IBU policies. >- Change oadp cm policy generation through PGT instead of a given policy file. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Missxiaoguo commented 4 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 4 months ago

@Missxiaoguo: #1896 failed to apply on top of branch "release-4.15":

Applying: ztp: Add IBU examples
.git/rebase-apply/patch:65: trailing whitespace.
As shown in the example below, this will create a Configmap named `oadp-cm` in the namespace `ztp-group` namespace on the hub cluster. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M   ztp/gitops-subscriptions/argocd/example/image-based-upgrades/README.md
Falling back to patching base and 3-way merge...
Removing ztp/gitops-subscriptions/argocd/example/image-based-upgrades/example-oadp-policy.yaml
Auto-merging ztp/gitops-subscriptions/argocd/example/image-based-upgrades/README.md
CONFLICT (content): Merge conflict in ztp/gitops-subscriptions/argocd/example/image-based-upgrades/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ztp: Add IBU examples
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1896#issuecomment-2187706308): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Missxiaoguo commented 4 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 4 months ago

@Missxiaoguo: #1896 failed to apply on top of branch "release-4.15":

Applying: ztp: Add IBU examples
.git/rebase-apply/patch:65: trailing whitespace.
As shown in the example below, this will create a Configmap named `oadp-cm` in the namespace `ztp-group` namespace on the hub cluster. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M   ztp/gitops-subscriptions/argocd/example/image-based-upgrades/README.md
Falling back to patching base and 3-way merge...
Removing ztp/gitops-subscriptions/argocd/example/image-based-upgrades/example-oadp-policy.yaml
Auto-merging ztp/gitops-subscriptions/argocd/example/image-based-upgrades/README.md
CONFLICT (content): Merge conflict in ztp/gitops-subscriptions/argocd/example/image-based-upgrades/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ztp: Add IBU examples
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1896#issuecomment-2187767627): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Missxiaoguo commented 4 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 4 months ago

@Missxiaoguo: new pull request created: #1952

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1896#issuecomment-2190047732): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.