search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

[release-4.12] OCPBUGS-33779: ztp: Add one-shot time sync on boot #1907

Closed openshift-cherrypick-robot closed 5 months ago

openshift-cherrypick-robot commented 5 months ago

This is an automated cherry-pick of #1898

/assign lack

openshift-ci-robot commented 5 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33349 has been cloned as Jira Issue OCPBUGS-33779. Will retitle bug to link to clone. /retitle [release-4.12] OCPBUGS-33779: ztp: Add one-shot time sync on boot

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1907): >This is an automated cherry-pick of #1898 > >/assign lack Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 5 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-33779, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1907): >This is an automated cherry-pick of #1898 > >/assign lack Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lack commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@lack: This pull request references Jira Issue OCPBUGS-33779, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1907#issuecomment-2116214788): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lack commented 5 months ago

/approve

lack commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@lack: This pull request references Jira Issue OCPBUGS-33779, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-33349](https://issues.redhat.com//browse/OCPBUGS-33349) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-33349](https://issues.redhat.com//browse/OCPBUGS-33349) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @mpmaruthu

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1907#issuecomment-2116296986): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mpmaruthu.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1907#issuecomment-2116297109): >@lack: This pull request references [Jira Issue OCPBUGS-33779](https://issues.redhat.com//browse/OCPBUGS-33779), which is valid. The bug has been moved to the POST state. > >
7 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.12.z) matches configured target version for branch (4.12.z) >* bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) >* release note text is set and does not match the template >* dependent bug [Jira Issue OCPBUGS-33349](https://issues.redhat.com//browse/OCPBUGS-33349) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) >* dependent [Jira Issue OCPBUGS-33349](https://issues.redhat.com//browse/OCPBUGS-33349) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z >* bug has dependents

Requesting review from QA contact: /cc @mpmaruthu

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1907#issuecomment-2116296986): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sabbir-47 commented 5 months ago

/lgtm

sabbir-47 commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack, openshift-cherrypick-robot, sabbir-47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/release-4.12/ztp/OWNERS)~~ [lack] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33779: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33779 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1907): >This is an automated cherry-pick of #1898 > >/assign lack Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.