search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

OCPBUGS-33597: Add TIMELS indication on T-GMs #1914

Closed vitus133 closed 5 months ago

vitus133 commented 5 months ago

This commit enables NAV-TIMELS indications on WPC T-GM configurations. This is required to enable automatic leap seconds file update. The phc2sys options are also changed to obtain the leap seconds from phc instead of passing them as the command line argument /cc @josephdrichard @jzding @aneeshkp @nishant-parekh

openshift-ci-robot commented 5 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-33597, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1914): >This commit enables NAV-TIMELS indications on WPC T-GM configurations. This is required to enable automatic leap seconds file update > >/cc @josephdrichard @jzding @aneeshkp @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-33597, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1914#issuecomment-2132918799): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-33597, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1914#issuecomment-2132920205): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 5 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-33597, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1914): >This commit enables NAV-TIMELS indications on WPC T-GM >configurations. This is required to enable automatic >leap seconds file update. >The phc2sys options are also changed to obtain the leap >seconds from phc instead of passing them as the command >line argument >/cc @josephdrichard @jzding @aneeshkp @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [vitus133] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

@vitus133: Jira Issue OCPBUGS-33597: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-33597 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1914): >This commit enables NAV-TIMELS indications on WPC T-GM >configurations. This is required to enable automatic >leap seconds file update. >The phc2sys options are also changed to obtain the leap >seconds from phc instead of passing them as the command >line argument >/cc @josephdrichard @jzding @aneeshkp @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aneeshkp commented 4 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 4 months ago

@aneeshkp: new pull request created: #1929

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1914#issuecomment-2159554760): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.