search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

OCPBUGS-33524: change ptp4lOpts from empty spaced string to null #1918

Closed aneeshkp closed 5 months ago

aneeshkp commented 5 months ago

In linuxPTPDaemon, a string containing a space character (" ") is not considered nil, whereas an empty string ("") is considered nil. The nil value determines whether to execute the processes related to the configured Opts. For an example

  1. ptp4lOpts: " " will run the ptp4l process with empty options
  2. ptp4lOpts: "" will not run the ptp4l process
openshift-ci-robot commented 5 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-33524, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1918): >In linuxPTPDaemon, a string containing a space character (" ") is not considered nil, whereas an empty string ("") is considered nil. The nil value determines whether to execute the processes related to the configured Opts. >For an example >1. ptp4lOpts: " " will run the ptp4l process with empty options >2. ptp4lOpts: "" will not run the ptp4l process Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aneeshkp commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-33524, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1918#issuecomment-2142330301): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aneeshkp commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-33524, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1918#issuecomment-2142335299): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aneeshkp commented 5 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 5 months ago

@aneeshkp: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1918#issuecomment-2142350341): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 5 months ago

@aneeshkp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ran-profile 7b70c7718ad7184663b15ad33d350d1de05f4ee4 link false /test e2e-aws-ran-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
nishant-parekh commented 5 months ago

/approve

sabbir-47 commented 5 months ago

/test e2e-aws-ran-profile

sabbir-47 commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding, nishant-parekh, sabbir-47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [nishant-parekh,sabbir-47] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

@aneeshkp: Jira Issue OCPBUGS-33524: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33524 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1918): >In linuxPTPDaemon, a string containing a space character (" ") is not considered nil, whereas an empty string ("") is considered nil. The nil value determines whether to execute the processes related to the configured Opts. >For an example >1. ptp4lOpts: " " will run the ptp4l process with empty options >2. ptp4lOpts: "" will not run the ptp4l process Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 5 months ago

@aneeshkp: new pull request created: #1924

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1918#issuecomment-2142350341): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.