search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

OCPBUGS-34914: remove leapfile from reference config #1920

Closed vitus133 closed 5 months ago

vitus133 commented 5 months ago

Leapfile is managed by linuxptp-daemon, but still appears in the reference config. This config entry will also be logged, which is misleading. This commit removes the entry from the reference config ts2phcConf section.

/cc @aneeshkp @josephdrichard @jzding @nishant-parekh

openshift-ci-robot commented 5 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-34914, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1920): >Leapfile is managed by linuxptp-daemon, but still appears in the reference config. This config entry will also be logged, which is misleading. This commit removes the entry from the reference config ts2phcConf section. > >/cc @aneeshkp @josephdrichard @jzding @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [vitus133] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@vitus133: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci f4e718d7262f35c8f74c2f01b12cc978a6c3dd04 link true /test ci
ci/prow/e2e-aws-ran-profile f4e718d7262f35c8f74c2f01b12cc978a6c3dd04 link false /test e2e-aws-ran-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
vitus133 commented 5 months ago

closing - will be done later as a tech debt

openshift-ci-robot commented 5 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-34914. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1920): >Leapfile is managed by linuxptp-daemon, but still appears in the reference config. This config entry will also be logged, which is misleading. This commit removes the entry from the reference config ts2phcConf section. > >/cc @aneeshkp @josephdrichard @jzding @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.