search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

CNF-12933: Adding OpenAPI support for Custom CRs when using ACM Policy Generator #1925

Closed edcdavid closed 3 months ago

edcdavid commented 5 months ago

This PR is to integrate support for the openAPI support for custom CR added by policy-generator-plugin: https://github.com/open-cluster-management-io/policy-generator-plugin/pull/159

Missing:

openshift-ci-robot commented 5 months ago

@edcdavid: This pull request references CNF-12933 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1925): >Work in progress!! >This PR is to integrate support for the openAPI support for custom CR added by policy-generator-plugin: https://github.com/open-cluster-management-io/policy-generator-plugin/pull/159 > >Missing: >- Documentation >- New image containing latest version of policy-generator-plugin >- End to end testing > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
edcdavid commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@edcdavid: This pull request references CNF-12933 which is a valid jira issue.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1925#issuecomment-2153553908): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
edcdavid commented 3 months ago

/cc @irinamihai

edcdavid commented 3 months ago

/test e2e-aws-ran-profile

sabbir-47 commented 3 months ago

/lgtm

sabbir-47 commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edcdavid, sabbir-47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [sabbir-47] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment