search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
57 stars 134 forks source link

OCPBUGS-35105: Update ptpconfig to configure NAV-TIMELS to be periodically sent via the UBX-CFG-MSG message #1926

Closed aneeshkp closed 2 months ago

aneeshkp commented 3 months ago

This PR Updates ptpconfig to configure the hardware plugin to periodically send the u-blox command NAV-TIMELS via the UBX-CFG-MSG message. NAV-TIMELS carries information about leap dates and offsets. Required for T-WPC leap events cc @vitus133

openshift-ci-robot commented 3 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-35105, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1926): >This PR Updates ptpconfig to configure the hardware plugin to periodically send the u-blox command NAV-TIMELS via the UBX-CFG-MSG message. NAV-TIMELS carries information about leap dates and offsets. >Required for T-WPC leap events cc @vitus133 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aneeshkp commented 3 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 months ago

@aneeshkp: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1926#issuecomment-2155237062): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aneeshkp commented 3 months ago

/hold

aneeshkp commented 2 months ago

/unhold

aneeshkp commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-35105, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yliu127

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1926#issuecomment-2158578734): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, josephdrichard, nishant-parekh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [nishant-parekh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@aneeshkp: Jira Issue OCPBUGS-35105: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35105 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1926): >This PR Updates ptpconfig to configure the hardware plugin to periodically send the u-blox command NAV-TIMELS via the UBX-CFG-MSG message. NAV-TIMELS carries information about leap dates and offsets. >Required for T-WPC leap events cc @vitus133 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 months ago

@aneeshkp: #1926 failed to apply on top of branch "release-4.16":

Applying: ztp: update ptpconfig to configure NAV-TIMELS
Using index info to reconstruct a base tree...
M   ztp/source-crs/PtpConfigDualCardGmWpc.yaml
M   ztp/source-crs/PtpConfigGmWpc.yaml
Falling back to patching base and 3-way merge...
Auto-merging ztp/source-crs/PtpConfigGmWpc.yaml
CONFLICT (content): Merge conflict in ztp/source-crs/PtpConfigGmWpc.yaml
Auto-merging ztp/source-crs/PtpConfigDualCardGmWpc.yaml
CONFLICT (content): Merge conflict in ztp/source-crs/PtpConfigDualCardGmWpc.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ztp: update ptpconfig to configure NAV-TIMELS
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1926#issuecomment-2155237062): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aneeshkp commented 2 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 2 months ago

@aneeshkp: new pull request created: #1932

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1926#issuecomment-2160412737): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.