search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
57 stars 134 forks source link

cnf-tests: Read guaranteed CPU list for cgroupv2 #1930

Closed zeeke closed 2 months ago

zeeke commented 2 months ago

Guaranteed workload pods can be in a different cgroup if on the node there has been applied a PerformanceProfile.

The Cluster Node Tuning Operator configures the cpuset cgroup on specific condition and it doesn't come back to the original configuration when the node is moved to a differenent MachineConfigPool.

Update the DPDK test cases' logic to retrieve the list of dedicated CPUs.

Refs:

cc @gregkopels , @ffromani

SchSeba commented 2 months ago

Hi @zeeke please run fmt to make the ci happy

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/OWNERS)~~ [SchSeba,zeeke] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zeeke commented 2 months ago

/retest

zeeke commented 2 months ago

ci/prow/e2e-aws-ci-tests job failure:

now testing cnftests nto-performance: 6de4dcac - OCPBUGS-34972: perfprof: bump verbosiness of logs (#1075)
Failed to compile 1_performance:

go: errors parsing go.mod:
/go/src/github.com/openshift-kni/cnf-features-deploy/cnf-tests/submodules/cluster-node-tuning-operator/go.mod:3: invalid go version '1.22.0': must match format 1.23
/go/src/github.com/openshift-kni/cnf-features-deploy/cnf-tests/submodules/cluster-node-tuning-operator/go.mod:5: unknown directive: toolchain
...
[WARN] Tests failed:
Tier 2 tests for nto
Tier 2 tests for nto-performance
/go/src/github.com/openshift-kni/cnf-features-deploy

is addressed in:

zeeke commented 2 months ago

@ffromani , @SchSeba can you please take another look at this?

ffromani commented 2 months ago

/lgtm

zeeke commented 1 month ago

/cherrypick release-4.16

openshift-cherrypick-robot commented 1 month ago

@zeeke: new pull request created: #1976

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1930#issuecomment-2255602997): >/cherrypick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.