search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
57 stars 134 forks source link

Add ClusterImageSet CR in the whitelist of policies-app-project #1934

Closed borball closed 2 months ago

borball commented 2 months ago

We are managing the ClusterImageSets through the policies, as a result we need this in the whitelist of policies-app-project, otherwise the sync will fail due to error below:

time="2024-06-11T17:44:46Z" level=info msg="Adding resource result, status: 'SyncFailed', phase: '', message: 'resource hive.openshift.io:ClusterImageSet is not permitted in project policy-app-project'" application=openshift-gitops/policies kind=ClusterImageSet name=cluster-image-set-4-14-25-20240606 namespace=policies-sub phase=Sync syncId=00006-pQxCU

Similar PR for app-project: https://github.com/openshift-kni/cnf-features-deploy/pull/1880

openshift-ci[bot] commented 2 months ago

Hi @borball. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sabbir-47 commented 2 months ago

/needs-ok-to-test

sabbir-47 commented 2 months ago

/lgtm

sabbir-47 commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: borball, sabbir-47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/release-4.16/ztp/OWNERS)~~ [sabbir-47] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment