openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
57 stars 134 forks source link

infra: Bump go v1.22 in CI jobs #1935

Closed zeeke closed 2 months ago

zeeke commented 2 months ago

Prow jobs like e2e-aws-ci-tests uses runs using the openshift-ci/Dockerfile.tools iamge. (See https://github.com/openshift/release/blob/0a257490e7c4aba7c6164bd79626791ed3dae819/ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-master.yaml#L21, where the job has from: src and the file has

build_root:
  project_image:
    dockerfile_path: openshift-ci/Dockerfile.tools
```)

This bump is needed because a submodule (cluster-node-tuning-operator in this case) bumped to go1.22 and jobs are reporting the error:

go: errors parsing go.mod: /go/src/github.com/openshift-kni/cnf-features-deploy/cnf-tests/submodules/cluster-node-tuning-operator/go.mod:3: invalid go version '1.22.0': must match format 1.23 /go/src/github.com/openshift-kni/cnf-features-deploy/cnf-tests/submodules/cluster-node-tuning-operator/go.mod:5: unknown directive: toolchain

SchSeba commented 2 months ago

/lgtm /approve

/override ci/prow/e2e-aws-ci-tests

/hold

giving time for the RAN team to make the require changes on the ztp container image

openshift-ci[bot] commented 2 months ago

@SchSeba: Overrode contexts on behalf of SchSeba: ci/prow/e2e-aws-ci-tests

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1935#issuecomment-2190711322): >/lgtm >/approve > >/override ci/prow/e2e-aws-ci-tests > >/hold > >giving time for the RAN team to make the require changes on the ztp container image Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/OWNERS)~~ [SchSeba,zeeke] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zeeke commented 2 months ago

@lack , @sabbir-47 I'm trying to upgrade CI images to 4.17 and go1.22 with these PR.

If you mind, I can bump ztp/resource-generator/Containerfile too.

lack commented 2 months ago

/lgtm

zeeke commented 2 months ago

/hold cancel