search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
59 stars 135 forks source link

ztp: DU profile RDS rules to work with kube-compare #1940

Closed pixelsoccupied closed 3 months ago

pixelsoccupied commented 4 months ago

This PR introduces go template validation rules around DU profile RDS. The rules should be able to run with kube-compare

Required and Optional RDS are structured based on upstream doc

pixelsoccupied commented 4 months ago

/cc @nocturnalastro

pixelsoccupied commented 4 months ago

/hold Making some review changes

irinamihai commented 4 months ago

Hey, @pixelsoccupied! Really nice to see templating leveraged here. :rocket: I'm wondering if it would be an option to avoid having 2 sets of source-crs. Including them in the manner you're proposing in this PR creates yet another location where these CRs need to be kept in sync and updated manually.

pixelsoccupied commented 4 months ago

yet another location where these CRs need to be kept in sync

Absolutely....I'm not a fan of this also. Ultimately we need some kind of tooling satisfy the need for "legacy" source-crs used by PGT and only keep this go-template/kube-compare version. I'll follow up with you and Ian for brainstorming and track this work better

nocturnalastro commented 4 months ago

@pixelsoccupied @irinamihai I wonder if we could produce the templates from normal source-crs + some kustomize overlays or recreate the normal source-crs from the templates?

AlinaSecret commented 4 months ago

@nocturnalastro The plan is to recreate the source-crs from the templates, its in progress :) @imiller0 @pixelsoccupied are there any reasons to change the plan?

imiller0 commented 3 months ago

/retest

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, pixelsoccupied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [imiller0] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pixelsoccupied commented 3 months ago

/unhold

imiller0 commented 3 months ago

/retest